Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Numeric type audit in transaction and block structs and provider methods, remove gratuitous U256s #433

Closed
prestwich opened this issue Apr 1, 2024 · 1 comment
Closed

[Bug] Numeric type audit in transaction and block structs and provider methods, remove gratuitous U256s #433

prestwich opened this issue Apr 1, 2024 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@prestwich
Copy link
Member

prestwich commented Apr 1, 2024 •
edited
Loading

Component

consensus, eips, genesis

What version of Alloy are you on?

No response

Operating System

None

Describe the bug

Noticed discrepancy while implementing From<TypedTransaction> for TransactionRequest

all types should have the following (with options as necessary)

applies to
consensus
rpc
providers return values
etc

block_number: u64

transaction_index: u64

gas_price: u128

// make sure names are consistent here too. these are the same field
gas: u128
gas_limit: u128

max_fee_per_gas: u128

max_priority_fee_per_gas: u128

max_fee_per_blob_gas: u128

value: U256
@prestwich prestwich added bug Something isn't working good first issue Good for newcomers labels Apr 1, 2024
@prestwich prestwich changed the title [Bug] Numeric type audit, remove gratuitous U256s [Bug] Numeric type audit in transaction structs, remove gratuitous U256s Apr 1, 2024
This was referenced Apr 2, 2024
Closed
Closed
@prestwich prestwich changed the title [Bug] Numeric type audit in transaction structs, remove gratuitous U256s [Bug] Numeric type audit in transaction and block structs, remove gratuitous U256s Apr 2, 2024
@prestwich prestwich changed the title [Bug] Numeric type audit in transaction and block structs, remove gratuitous U256s [Bug] Numeric type audit in transaction and block structs and provider methods, remove gratuitous U256s Apr 2, 2024
@yash-atreya yash-atreya mentioned this issue Apr 3, 2024
Merged
3 tasks
@prestwich
Copy link
Member Author

closed by 454

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@prestwich