fix: correctly treat confirmation
for watch_pending_transaction
#381
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Current logic was not treating
confirmations
in the expected way (tx being included = 1 confirmation)Also
split_off
splits off keys including the one at which split is being performed, thus we actually notifiedTxWatcher
about txses one block laterTwo open questions:
watch_pending_transaction
will indefinitely wait for a block with targeted tx. Is this expected? Feels like a footgun, especially considering that we don't have a default timeoutwatch_pending_transaction
users specifyingconfirmations > 1
would also be interested in ensuring that no reorg has happened and that tx is actually on-chain, should we add a parameter for that?