fix(transaction-request): Support HEX TransactionRequest.chain_id
#344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…per Ethereum JSON-RPC specification.
kustrun
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg and
prestwich
as code owners
onbjerg
approved these changes
Mar 20, 2024
kien-rise
added a commit
to kien-rise/alloy
that referenced
this pull request
Mar 29, 2024
…n_id as per Ethereum JSON-RPC specification. (alloy-rs#344)" This reverts commit 15529a4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support HEX TransactionRequest.chain_id` as per Ethereum JSON-RPC specification.
Motivation
While switching between node clients (GETH and RETH) there was an inconsistency in the
TransactionRequest.chain_idimplementation.To support the behavior, specified in Ethereum JSON-RPC specification the
chain_idserialization was extended to supporthex input.
Specs: https://ethereum.github.io/execution-apis/api-documentation/
Solution
Reuse custom serializer, already implemented for
noncefield to support hex input forchain_idfield.PR Checklist