Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Alloy to easily convert from alloy_rpc_types::Transaction to alloy_concensus::transaction::Transaction #169

Closed
ZanCorDX opened this issue Jan 31, 2024 · 7 comments
Labels
enhancement New feature or request

Comments

@ZanCorDX
Copy link

Component

network, json-rpc

Describe the feature you would like

The reason I need this right now is to be able to subscribe to newPendingTransactions and generate a rlp encoded txs from the tx stream.

Additional context

No response

@ZanCorDX ZanCorDX added the enhancement New feature or request label Jan 31, 2024
@DaniPopes
Copy link
Member

DaniPopes commented Mar 14, 2024

Is this done? cc @mattsse @onbjerg
RLP <-> RPC

In any case you can use Provider::subscribe_full_pending_transactions and build whatever transaction you want from the fields

@onbjerg
Copy link
Member

onbjerg commented Mar 19, 2024

it is not

@prestwich
Copy link
Member

ideally this should be done by embedding a consensus transactionenvelope into the rpc response

@mattsse
Copy link
Member

mattsse commented Mar 19, 2024

cc @klkvr

imo we could either solve this by impl a tryform to consensus transaction from rpc
or solve this via some helper trait

@ZanCorDX
Copy link
Author

We solved the problem by subscribing to newPendingTransactions + calling eth_getRawTransactionByHash.

@prestwich prestwich reopened this Mar 20, 2024
@prestwich
Copy link
Member

reopening due to ongoing work

@prestwich
Copy link
Member

closed by #344 and #338 and #365

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants