feat: impl From<Transaction> for TransactionRequest + small type updates
#338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klkvr
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg and
prestwich
as code owners
klkvr
changed the title
impl From<Transaction> for TransactionRequest + small type updates
mattsse
requested changes
Mar 18, 2024
Comment on lines
+240
to
+244
| impl From<Transaction> for TransactionRequest { | ||
| fn from(tx: Transaction) -> TransactionRequest { |
There was a problem hiding this comment.
this is definitely useful, for example,
eth_getTransaction
-> eth_call
so I think we want/need this.
The missing blob is also not problematic because this will be used mostly for calls.
and there's nothing we can do without the blob anyway
mattsse
approved these changes
Mar 18, 2024
mattsse
reviewed
Mar 18, 2024
mattsse
approved these changes
Mar 18, 2024
klkvr
force-pushed
the
klkvr/impl-from-tx-request
branch
from
bed2e9d
to
47e349f
Compare
3 tasks
onbjerg
reviewed
Mar 19, 2024
| /// | ||
| /// During this conversion data for [TransactionRequest::sidecar] is not populated as it is not | ||
| /// part of [Transaction]. | ||
| pub fn into_request(self) -> TransactionRequest { |
There was a problem hiding this comment.
any reason we have this instead of just the auto-impl'd Into we get from From?
There was a problem hiding this comment.
We wanted to have it documented on Transaction
Ref #338 (comment)
mattsse
reviewed
Mar 19, 2024
klkvr
force-pushed
the
klkvr/impl-from-tx-request
branch
from
fc028c1
to
65b6391
Compare
3 tasks
mattsse
approved these changes
Mar 20, 2024
onbjerg
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This was in ethers and is being used in foundry: https://github.com/foundry-rs/foundry/blob/master/crates/common/src/transactions.rs#L43
Transactiondoes not include sidecar so this conversion is not losslessI've also updated several field types on
Transactionso they matchTransactionRequesttypes.Transaction::chain_idchanged to u64 to matchTransactionRequestTransaction::access_listchanged to useAccessListstructTransaction::transaction_typechanged toU8(Ethereum spec defines it as a number <=127, Optimism deposit transaction has type 126).PR Checklist