chore: deduplicate AccessList and Withdrawals types #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 15, 2024 15:52
JackG-eth
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg and
prestwich
as code owners
mattsse
requested changes
Mar 16, 2024
mattsse
requested changes
Mar 18, 2024
3 tasks
mattsse
approved these changes
Mar 21, 2024
|
fyi @klkvr with this AccessList types are deduplicated |
|
Can we get a more descriptive PR name and "closes #..." tags? |
mattsse
changed the title
3 tasks
|
can you also remove alloy/crates/network/src/ethereum/builder.rs Line 229 in e8c622c |
|
done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #255
deduplicates AccessList+Withdrawals by moving them into eips crate and reusing them in rpc and consensus