-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(engine): no_std engine types #1268
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refcell
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg,
prestwich and
emhane
as code owners
September 10, 2024 15:45
refcell
force-pushed
the
rf/rebase/no-std-engine
branch
from
September 10, 2024 15:49
9be5f0f
to
a42c4e8
Compare
mattsse
requested changes
Sep 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
last nits
mattsse
approved these changes
Sep 11, 2024
lwedge99
pushed a commit
to sentioxyz/alloy
that referenced
this pull request
Oct 8, 2024
* feat: support no_std in alloy-rpc-types-eth * feat: derive_more error * ci: add no-std check * ci: update script * fix: crate collections * fix: fmt * chore: remove unused hash_map re-export * feat: converts engine rpc types to no-std * feat: derive_more display + std feature * fix: jwt feat * fix: clippy warnings * fix: clippy warnings * fix: error source * fix: remove tree * fix: std * fix: std * fix: std * fix: dep * fix: fmt * fix: ssz derive depends on std * fix: missing deps jwt feat * fix: raw duration * fix: fmts * touchups * fix: last nits * fix: remove core result * fix: remove manual result imports * fix: fmts --------- Co-authored-by: Matthias Seitz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Note
Blocked by #1252
Adds
no_std
for thealloy-rpc-types-engine
crate.This PR replaces #1233 and is stacked ontop of #1252