Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addition of engine rpc-types from reth #118

Merged
merged 7 commits into from
Jan 17, 2024
Merged

Addition of engine rpc-types from reth #118

merged 7 commits into from
Jan 17, 2024

Conversation

1010adigupta
Copy link
Contributor

@1010adigupta 1010adigupta commented Jan 16, 2024 •
edited
Loading

Motivation

This pr aims to add engine related rpc-types to alloy.
closes paradigmxyz/reth#5989

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@1010adigupta 1010adigupta marked this pull request as draft January 16, 2024 22:20
mattsse
mattsse requested changes Jan 16, 2024
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great draft!

I'd all of this in a new crate rpc-engine-types

@1010adigupta 1010adigupta marked this pull request as ready for review January 17, 2024 12:34
mattsse
mattsse approved these changes Jan 17, 2024
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice job!

now we can replace this in reth-rpc-types and simply reexport everything in the engine module there

Evalir
Evalir approved these changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@Evalir Evalir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks! just wanna make sure we're not copy extra unused deps

crates/rpc-engine-types/Cargo.toml Outdated Show resolved Hide resolved
@1010adigupta
Copy link
Contributor Author

nice job!

now we can replace this in reth-rpc-types and simply reexport everything in the engine module there

on it!
should I create a issue in reth for this, and attach a new pr there now?

@mattsse
Copy link
Member

mattsse commented Jan 17, 2024

nice job!
now we can replace this in reth-rpc-types and simply reexport everything in the engine module there

on it! should I create a issue in reth for this, and attach a new pr there now?

there's already the open issue, your PR should simply close this one!
thanks, merging this as soon as CI is green

@mattsse mattsse merged commit 454ccd6 into alloy-rs:main Jan 17, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Evalir Evalir Evalir approved these changes

@mattsse mattsse mattsse approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@prestwich prestwich Awaiting requested review from prestwich

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move engine related rpc types to alloy
3 participants
@1010adigupta @mattsse @Evalir