Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move engine related rpc types to alloy #5989

Closed
mattsse opened this issue Jan 9, 2024 · 3 comments · Fixed by alloy-rs/alloy#118
Closed

Move engine related rpc types to alloy #5989

mattsse opened this issue Jan 9, 2024 · 3 comments · Fixed by alloy-rs/alloy#118
Assignees
@1010adigupta
Labels
C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started S-blocked This cannot more forward until something else changes

Comments

@mattsse
Copy link
Collaborator

mattsse commented Jan 9, 2024 •
edited
Loading

Describe the feature

move engine related rpc types (reth-rpc-types/engine) to a new crate in alloy, similar to existing rpc types crates there

blocked by #5948

Additional context

No response
@mattsse mattsse added C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started labels Jan 9, 2024
@mattsse mattsse added the S-blocked This cannot more forward until something else changes label Jan 9, 2024
@1010adigupta
Copy link
Contributor

can take this

@mattsse
Copy link
Collaborator Author

mattsse commented Jan 10, 2024

triggered merge on #5948 that unblocks this

@1010adigupta 1010adigupta mentioned this issue Jan 16, 2024
Merged
3 tasks
@1010adigupta
Copy link
Contributor

@mattsse I have linked a pr here, kindly give review on it

@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@1010adigupta 1010adigupta

Labels
C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started S-blocked This cannot more forward until something else changes
Projects
Reth Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Addition of engine rpc-types from reth 1010adigupta/alloy
2 participants
@mattsse @1010adigupta