Replace manual path mucking with std::filesystem. #910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvander
force-pushed
the
builtins
branch
3 times, most recently
from
fb0c1a0 to
e547b29
Compare
This has a few side effects: - DIRSEP_CHAR and a lot of manual string code are gone. - This fixes how file defines were created, which was mostly broken and working by accident. - A weird feature where non-".sp" extensions were rewritten on the command-line has been removed. - This fixes an unrelated crash on the command-line if the input file was not found.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets rid of DIRSEP_CHAR and a lot of manual string code.
It also fixes how file defines were created, which was mostly broken and working by accident.
Finally, it fixes a crash on the command-line if the input file was not found.