Delay function body parsing. #905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch skips parsing function bodies, instead caching tokens and attaching the token stream to the AST. After the AST is built, functions are parsed using cached tokens. This is fairly easy to do thanks to the recent Lexer/SourceManager refactoring. This is a critical step toward collapsing the binding and semantic passes together, without re-introducing a dreaded reparse phase. A quick estimate shows that memory use on this is pretty small. For funcommands.sp (the biggest plugin in the test suite), it's about 200KB. This is again thanks to the recent refactoring. Tokens are now 24 bytes instead of 96 bytes. Duplicating the AST would use about 3MB since the AST is so unoptimized, and culling that down is a big project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch skips parsing function bodies, instead caching tokens and attaching the token stream to the AST. After the AST is built, functions are parsed using cached tokens. This is fairly easy to do thanks to the recent Lexer/SourceManager refactoring.
This is a critical step toward collapsing the binding and semantic passes together, without re-introducing a dreaded reparse phase.
A quick estimate shows that memory use on this is pretty small. For funcommands.sp (the biggest plugin in the test suite), it's about 200KB. This is again thanks to the recent refactoring. Tokens are now 24 bytes instead of 96 bytes.
Duplicating the AST would use about 3MB since the AST is so unoptimized, and culling that down is a big project.