Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for rsync-ing a codebase from within the testing suite #332

Merged
merged 19 commits into from
Oct 25, 2022

Conversation

srtfisher
Copy link
Member

@srtfisher srtfisher commented Oct 11, 2022

Add support for rsyncing a codebase (either a plugin/theme or wp-content) to within a WordPress installation -- all within the codebase. Removes the need for rsync-ing externally.

  • The system will have support for rsyncing the project to a plugin/theme within a WordPress installation. The PHPUnit will be rerun from the new location after rsyncing is complete.
  • Introduces Termwind to help manage the UI of the unit tests.
  • Abstracts the install WordPress logic to a utility class method.

@srtfisher srtfisher marked this pull request as draft October 11, 2022 21:23
@srtfisher srtfisher changed the title rsync theme Add support for rsync-ing a codebase from within the testing suite Oct 11, 2022
@srtfisher srtfisher marked this pull request as ready for review October 24, 2022 21:04
Copy link
Contributor

@mogmarsh mogmarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have a couple .DS_Store files included and I found a couple other small things. Otherwise 👍

Comment on lines +27 to +31
string $prefix,
string $prefix_color,
string $message,
string $message_color = 'white',
string $parent_classes = '',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need additional defaults?

);

if ( 0 !== $retval ) {
Utils::error( '🚨 Error installing rsyncing! Output from command:', 'Install Rsync' );
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

slight grammar issue?

WP_PHP_BINARY,
escapeshellarg( __DIR__ . '/install-wordpress.php' ),
$multisite,
// Utils::get_autoloader_path()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commented code

@srtfisher srtfisher merged commit c53c426 into main Oct 25, 2022
@srtfisher srtfisher deleted the rsync-theme branch October 25, 2022 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants