Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assert Json Structure and other testing improvements #286

Merged
merged 13 commits into from
Jun 27, 2022
Merged

Assert Json Structure and other testing improvements #286

merged 13 commits into from
Jun 27, 2022

Conversation

srtfisher
Copy link
Member

@srtfisher srtfisher commented Jun 24, 2022 •
edited
Loading

  • Renaming to Test_Interacts_With_External_Requests to clarify the intent of the test
  • Moving all JSON tests to Assertable_Json_String -- a broken out class for asserting against JSON. More tests will be added in the future to it!
  • Adding assertJsonStructure method
  • Wiring up the response to take a JsonSerializable straight

@srtfisher srtfisher changed the title assert json Assert Json Structure and other testing improvements Jun 24, 2022
mogmarsh
mogmarsh approved these changes Jun 27, 2022
View reviewed changes
Copy link
Contributor

@mogmarsh mogmarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍

@srtfisher srtfisher merged commit b322ab2 into main Jun 27, 2022
@srtfisher srtfisher deleted the assert-json branch June 27, 2022 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mogmarsh mogmarsh mogmarsh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@srtfisher @mogmarsh