Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit timeout for subscriber creation #1029

Merged
merged 2 commits into from
Jun 10, 2024
Merged

Add explicit timeout for subscriber creation #1029

merged 2 commits into from
Jun 10, 2024

Conversation

allenporter
Copy link
Owner

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jun 10, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 92.83%. Comparing base (9ead159) to head (2632a5a).

Files Patch % Lines
google_nest_sdm/google_nest_subscriber.py 66.66% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1029      +/-   ##
==========================================
- Coverage   92.97%   92.83%   -0.14%     
==========================================
  Files          19       19              
  Lines        1821     1829       +8     
==========================================
+ Hits         1693     1698       +5     
- Misses        128      131       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@allenporter allenporter merged commit 844715d into main Jun 10, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants