This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
context manager that allows predictor to capture model internals #2581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this is pretty slick. I have no complaints with this approach. One issue I see in using this in a demo is deciding which things to show to the user. That will have to be configured somewhere (e.g., you might consider taking a filter function or something as an argument to the context manager). But getting the internals this way seems great. |
|
There's also the issue of wanting to get internals that aren't the result of submodules, but this is definitely an improvement over the current situation. Most things we would want to include in a demo are probably the output of a module, anyway. |
matt-gardner
approved these changes
Mar 13, 2019
| # If you capture the return value of the context manager, you get the results dict. | ||
| yield results | ||
|
|
||
| # And then when you exit the context we remove all the hooks. |
There was a problem hiding this comment.
Thanks for these comments - I'm not familiar with how context managers work, so this helps a lot.
reiyw
pushed a commit
to reiyw/allennlp
that referenced
this pull request
Nov 12, 2019
…enai#2581) * model internals * undo formatting change * more undo formatting * work * mypy + docs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as I said, this approach is slightly on the "cute" side, but I like how utterly non-intrusive it is