New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support cross-platform docker images #157

Open

raohuaming wants to merge 1 commit into allegroai:master from raohuaming:master

raohuaming commented Aug 25, 2022

Support using buildx to build cross-platform images:

$ docker buildx create --name clearml-server --use
$ docker buildx build -f docker/build/Dockerfile --platform linux/arm64,linux/amd64 -t  raohuaming/clearml:v1.6.0 --push .


          feat: support cross-built docker images

02e6663

Member

jkhenning commented Sep 5, 2022

Hi @raohuaming ,

Thanks for this contribution. I'm not sure I understand how to build for cross-platform, can you please explain?
In general, I would prefer to:

Have an additional build target/script/Dockerfiles for this cross-platform build and keep the original build as is
Since the server repository is used for development and not only for deployment (mostly for development), I would prefer not to use git submodules as we prefer to use these for code submodules that are required for development, not deployment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet