use envoy version with segfault fix #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukidzi
previously approved these changes
Nov 19, 2020
chemicL
reviewed
Nov 19, 2020
| @@ -32,7 +32,7 @@ class EnvoyContainer( | |||
|
|
|||
| const val EGRESS_LISTENER_CONTAINER_PORT = 5000 | |||
| const val INGRESS_LISTENER_CONTAINER_PORT = 5001 | |||
| const val DEFAULT_IMAGE = "envoyproxy/envoy-alpine:v1.14.3" | |||
| const val DEFAULT_IMAGE = "marcinfalkowski/envoy-dev:v1.16.1-dev-lua-segfault-fix-1-16-0-backport-20201118-df9dc819" | |||
There was a problem hiding this comment.
Can we fork it on official allegro account not to use your personal?
There was a problem hiding this comment.
I will do it in next PR, when our official fork will be ready
slonka
reviewed
Nov 20, 2020
|
|
||
| ENV PORT=9999:9999 | ||
| ENV PORT=80:80 | ||
| ENV ENVOY_NODE_ID=front-proxy-id | ||
| ENV ENVOY_NODE_CLUSTER=front-proxy | ||
| ENV ENVOY_EGRESS_LISTENER_PORT=80 | ||
| ENV ENVOY_INGRESS_LISTENER_PORT=8080 | ||
| ENV ENVOY_EGRESS_LISTENER_PORT=31000 |
There was a problem hiding this comment.
Is the port change relevant / needed?
There was a problem hiding this comment.
yes, new envoy container versions launch envoy from user envoy, not root, which has no access to low ports
lukidzi
approved these changes
Nov 20, 2020
andrzejwaw
approved these changes
Nov 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use envoy with a fix envoyproxy/envoy#14092 backported to envoy v1.16.0