Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log remote status when push release task failed #829

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

weih-kahoot
Copy link
Contributor

Similar to what's been done in PR #685 for release task.

Similar to what's been done in PR allegro#685 for release task.
@bgalek
Copy link
Member

bgalek commented Oct 2, 2024

LGTM, thx ;)

@bgalek bgalek merged commit a158fe6 into allegro:main Oct 2, 2024
1 check passed
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 63.66%. Comparing base (9041e39) to head (fa4c79c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ro/tech/build/axion/release/PushReleaseTask.groovy 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #829      +/-   ##
============================================
- Coverage     63.74%   63.66%   -0.08%     
  Complexity      442      442              
============================================
  Files            82       82              
  Lines          1633     1635       +2     
  Branches        161      161              
============================================
  Hits           1041     1041              
- Misses          523      525       +2     
  Partials         69       69              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@weih-kahoot weih-kahoot deleted the push-release-task-log branch October 3, 2024 05:16
@weih-kahoot
Copy link
Contributor Author

@bgalek Thanks for the quick review, I wonder if it's possible to make a new release(a snapshot is also fine)? This should help in debugging push task release failure I'm facing on CI.

@bgalek
Copy link
Member

bgalek commented Oct 3, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants