Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use nearest zero-based pool name for expansion #48

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

allanrogerr
Copy link
Owner

@allanrogerr allanrogerr commented Jan 24, 2024

Issue summary

After tenant expansion and decommission, further expansion is not always possible using the MinIO tenant console.

As an example, in a deployment with pool-0 and pool-1, after pool-0 decommission, a subsequent expansion by the console tries and fails to create pool-1 which already exists.

This is because the MinIO tenant console automatically names pools based on the number of pools in existence. If there is 1 pool, then the logic will try to create pool-1 - which may be incorrect as shown above. This logic needs to consider examining the pools already in existence before determining which pool name to use.

Test summary

Reproduce issue on master
Test 0 - As reported by user, Create using Console, Expand using Console, Decommission pool-0, Expand tenant using Console

Fix on improve-poolname-search branch
Test 1 - Create tenant using console, Expand using kubectl-minio, Decommission pool-0, Expand tenant using Console
Test 2 - Create tenant using kubectl-minio, Expand using console, Decommission 0pool, Expand tenant using Console
Test 3 - As reported by user, Create tenant using Console, Expand tenant using Console, Decommission pool-0, Expand tenant using Console
Test 4 - Create tenant using kubectl, Expand tenant using kubectl, Decommission pool-1, Expand tenant using Console

Verbose tests here:
https://github.com/allanrogerr/public/wiki/operator%E2%80%901785

@allanrogerr allanrogerr self-assigned this Jan 24, 2024
@allanrogerr allanrogerr changed the title Search pool names naively for the largest numeric suffix, then increment as a suffix. If none is found then add a new suffix Use nearest zero-based pool name Jan 24, 2024
@allanrogerr allanrogerr changed the title Use nearest zero-based pool name Use nearest zero-based pool name for expansion Jan 24, 2024
@allanrogerr allanrogerr force-pushed the improve-poolname-search branch from 78c867d to 14cb578 Compare January 24, 2024 14:06
@allanrogerr allanrogerr force-pushed the improve-poolname-search branch from 14cb578 to 2213bf4 Compare January 24, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant