Stop converting punct when converting scripts #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When converting from/to simplified/traditional, keep the punctuation chars as-is. There should be no need to convert from Latin punctuation to Chinese punctuation, so I removed that part.
| @@ -297,7 +286,7 @@ inline std::string Parser<T>::romanize_segment(int segmentNbr) { | |||
| if (tempItem != NULL) { | |||
| temp += tempItem->romanization; | |||
| } else { | |||
| temp += convert_trash_segment(segments[segmentNbr], true); | |||
There was a problem hiding this comment.
shouln't it still be here for romanization (i.e Chinese -> Pinyin) conversion ?
There was a problem hiding this comment.
It’s still here, see the next line below. I only removed the second parameter.
allan-simon
added a commit
that referenced
this pull request
Nov 21, 2015
Stop converting punct when converting scripts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When converting from/to simplified/traditional, keep the punctuation chars
as-is. There should be no need to convert from Latin punctuation to Chinese
punctuation, so I removed that part.
Before the fix:
After the fix: