Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: define research and promotion contribution types #428

Merged
merged 1 commit into from
Oct 4, 2022
Merged

fix: define research and promotion contribution types #428

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/parse-comment.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,8 @@ const validContributionTypes = [
"tutorial",
"usertesting",
"video",
"research",
"promotion",
Copy link
Member

@tenshiAMD tenshiAMD Oct 4, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

U mean adding emoji in docs here

https://github.com/all-contributors/all-contributors/blob/master/docs/emoji-key.md

];

// Types that are valid multi words, that we need to re map back to their camelCase parts
Expand Down Expand Up @@ -91,6 +93,7 @@ const contributionTypeMappings = {
translations: "translation",
tutorials: "tutorial",
videoes: "video",
advertisement: "promotion",
};

// Additional terms to match to types (plurals, aliases etc) that are multi word
Expand All @@ -108,6 +111,7 @@ const contributionTypeMultiWordMapping = {
"user testing": "userTesting",
"business development": "business",
"project management": "projectManagement",
"social media": "promotion",
};

const Contributions = {};
Expand Down