Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: commit conventions #343

Merged
merged 10 commits into from
Sep 12, 2022
Merged

feat: commit conventions #343

merged 10 commits into from
Sep 12, 2022

Conversation

Berkmann18
Copy link
Member

@Berkmann18 Berkmann18 commented Jan 18, 2021

Updated version of #200

@vercel
Copy link

vercel bot commented Jan 18, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/all-contributors-app/app/8yb7x41wc
✅ Preview: https://app-git-commit-conv.all-contributors-app.vercel.app

[Deployment for d84a210 failed]

@gr2m
Copy link
Contributor

gr2m commented Jan 18, 2021

@Berkmann18 if you want to test the deployment for this PR, you can update the webhook URL to https://app-git-commit-conv.all-contributors-app.vercel.app/api/github/webhooks at https://github.com/organizations/all-contributors/settings/apps/all-contributors-preview#integration_hook_attributes_active

@Berkmann18
Copy link
Member Author

The link 404s for me :/.

@gr2m
Copy link
Contributor

gr2m commented Jan 18, 2021

try again please

It would need to be aware of the configuration used to test for the other conventions
@gr2m
Copy link
Contributor

gr2m commented Oct 20, 2021

@Berkmann18 did you have a chance to see if it works? Can you rebase your PR on the latest changes?

@Berkmann18
Copy link
Member Author

@gr2m Not since I last worked on this which wasn't a high priority thing.

Copy link
Member

@tenshiAMD tenshiAMD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Berkmann18 Hi, please rebase to master branch first so we can proceed with this PR. Thanks!

@tenshiAMD
Copy link
Member

@gr2m Not since I last worked on this which wasn't a high priority thing.

@Berkmann18 Can I help check this one?

@tenshiAMD tenshiAMD added the enhancement New feature or request label Sep 6, 2022
@vercel
Copy link

vercel bot commented Sep 6, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
app ✅ Ready (Inspect) Visit Preview Sep 12, 2022 at 7:22PM (UTC)

@Berkmann18
Copy link
Member Author

@tenshiAMD I've resolved the conflict. And yeah, you can help check that.

@codecov
Copy link

codecov bot commented Sep 12, 2022

Codecov Report

Base: 99.21% // Head: 99.22% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (7da26e6) compared to base (98a3a02).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 7da26e6 differs from pull request most recent head 70fe001. Consider uploading reports for the commit 70fe001 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #343      +/-   ##
==========================================
+ Coverage   99.21%   99.22%   +0.01%     
==========================================
  Files          15       15              
  Lines         381      387       +6     
  Branches       46       47       +1     
==========================================
+ Hits          378      384       +6     
  Misses          3        3              
Impacted Files Coverage Δ
lib/add-contributor.js 100.00% <100.00%> (ø)
lib/modules/config.js 95.52% <100.00%> (+0.13%) ⬆️
lib/modules/repository.js 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tenshiAMD
Copy link
Member

@Berkmann18 if you want to test the deployment for this PR, you can update the webhook URL to https://app-git-commit-conv.all-contributors-app.vercel.app/api/github/webhooks at github.com/organizations/all-contributors/settings/apps/all-contributors-preview#integration_hook_attributes_active

@gr2m @Berkmann18 all looks good now. how can we test live?

Copy link
Member

@tenshiAMD tenshiAMD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Berkmann18 @gr2m almost forgot, we need to update the documentation regarding this one.

oh, it's already included here (https://github.com/all-contributors/all-contributors/blob/2fdeea1fbe1788e223d8f34923ab38ec6ab33934/docs/cli/configuration.md#L24)

@tenshiAMD
Copy link
Member

tenshiAMD commented Sep 12, 2022

@Berkmann18 @gr2m I think we should set the default to use angular since that's the currently being used right now

@tenshiAMD
Copy link
Member

Resolves #132

Copy link
Contributor

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍🏼

@gr2m gr2m merged commit e6c6571 into master Sep 12, 2022
@gr2m gr2m deleted the commit-conv branch September 12, 2022 19:24
@github-actions
Copy link

🎉 This PR is included in version 1.15.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

tenshiAMD added a commit that referenced this pull request Sep 12, 2022
…ing-multiple-users-in-a-single-message

* origin/master: (103 commits)
  feat: commit conventions (#343)
  refactor: remove unnecessary error handling (#410)
  chore: fix codecov (#409)
  chore: remove all Slack references (#407)
  docs: add tenshiAMD as a contributor for code, maintenance, bug, review, test (#408)
  chore(deps): bump validator and smee-client (#406)
  fix(deps): bump `all-contributors-cli` (#404)
  fix(package): bump `all-contributors-cli` (#403)
  chore(deps): bump async from 3.2.1 to 3.2.3 (#396)
  chore(deps): bump eventsource from 1.1.0 to 1.1.1
  chore(deps): bump minimist from 1.2.5 to 1.2.6
  chore(deps): bump url-parse from 1.5.7 to 1.5.10
  chore(deps): bump node-fetch from 2.6.5 to 2.6.7
  chore(deps): bump url-parse from 1.5.3 to 1.5.7
  fix: bump max number of files to 25 (#385)
  docs: add aaltat as a contributor for bug (#383)
  fix: set `webhooksPath` correctly
  fix: Probot v12 (#381)
  chore(deps): bump hosted-git-info from 2.8.8 to 2.8.9
  chore(deps): bump semver-regex from 3.1.2 to 3.1.3
  ...
@Berkmann18
Copy link
Member Author

@Berkmann18 @gr2m I think we should set the default to use angular since that's the currently being used right now

Not every repo use a commit convention and the setting was the users not just us.

@tenshiAMD
Copy link
Member

Not every repo use a commit convention and the setting was the users not just us.

@Berkmann18 yes that's true however in the app the default is using angular. is CLI currently using none?

@Berkmann18
Copy link
Member Author

They both should have been the same, it must have been a mistake or a leftover from some corrections.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request pinned released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants