-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: commit conventions #343
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/all-contributors-app/app/8yb7x41wc [Deployment for d84a210 failed] |
@Berkmann18 if you want to test the deployment for this PR, you can update the webhook URL to |
The link 404s for me :/. |
try again please |
It would need to be aware of the configuration used to test for the other conventions
@Berkmann18 did you have a chance to see if it works? Can you rebase your PR on the latest changes? |
@gr2m Not since I last worked on this which wasn't a high priority thing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Berkmann18 Hi, please rebase to master
branch first so we can proceed with this PR. Thanks!
@Berkmann18 Can I help check this one? |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@tenshiAMD I've resolved the conflict. And yeah, you can help check that. |
Codecov ReportBase: 99.21% // Head: 99.22% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #343 +/- ##
==========================================
+ Coverage 99.21% 99.22% +0.01%
==========================================
Files 15 15
Lines 381 387 +6
Branches 46 47 +1
==========================================
+ Hits 378 384 +6
Misses 3 3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@gr2m @Berkmann18 all looks good now. how can we test live? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Berkmann18 @gr2m almost forgot, we need to update the documentation regarding this one.
oh, it's already included here (https://github.com/all-contributors/all-contributors/blob/2fdeea1fbe1788e223d8f34923ab38ec6ab33934/docs/cli/configuration.md#L24)
@Berkmann18 @gr2m I think we should set the default to use |
Resolves #132 |
d351345
to
e08865a
Compare
e08865a
to
70fe001
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good 👍🏼
🎉 This PR is included in version 1.15.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
…ing-multiple-users-in-a-single-message * origin/master: (103 commits) feat: commit conventions (#343) refactor: remove unnecessary error handling (#410) chore: fix codecov (#409) chore: remove all Slack references (#407) docs: add tenshiAMD as a contributor for code, maintenance, bug, review, test (#408) chore(deps): bump validator and smee-client (#406) fix(deps): bump `all-contributors-cli` (#404) fix(package): bump `all-contributors-cli` (#403) chore(deps): bump async from 3.2.1 to 3.2.3 (#396) chore(deps): bump eventsource from 1.1.0 to 1.1.1 chore(deps): bump minimist from 1.2.5 to 1.2.6 chore(deps): bump url-parse from 1.5.7 to 1.5.10 chore(deps): bump node-fetch from 2.6.5 to 2.6.7 chore(deps): bump url-parse from 1.5.3 to 1.5.7 fix: bump max number of files to 25 (#385) docs: add aaltat as a contributor for bug (#383) fix: set `webhooksPath` correctly fix: Probot v12 (#381) chore(deps): bump hosted-git-info from 2.8.8 to 2.8.9 chore(deps): bump semver-regex from 3.1.2 to 3.1.3 ...
Not every repo use a commit convention and the setting was the users not just us. |
@Berkmann18 yes that's true however in the app the default is using |
They both should have been the same, it must have been a mistake or a leftover from some corrections. |
Updated version of #200