fix: define research and promotion contribution types
#428
Conversation
We are adding research and promotion keywords to parse-comment.js for Issue all-contributors#399
|
@201b153 is attempting to deploy a commit to the All Contributors Team on Vercel. A member of the Team first needs to authorize it. |
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #428 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 16 16
Lines 407 407
Branches 46 46
=========================================
Hits 407 407
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Do we have to add emojis too??
|
tenshiAMD
changed the title
research contribution type
There was a problem hiding this comment.
Do we have to add emojis too?? where I don't read it in the issue can u guide me here?
@201b153 Thanks for this one. LGTM now. I just noticed now that the emoji keys are in the CLI codebase. 😕 I think will do some refactoring later on regarding this one.
Ok, Thanks |
| @@ -35,6 +35,8 @@ const validContributionTypes = [ | |||
| "tutorial", | |||
| "usertesting", | |||
| "video", | |||
| "research", | |||
| "promotion", | |||
There was a problem hiding this comment.
TODO:
- Add an emoji key for
promotionin https://github.com/all-contributors/cli (feat: add contribution typepromotioncli#339) - Include
promotionin emoji key documentation in https://github.com/all-contributors/all-contributors
There was a problem hiding this comment.
U mean adding emoji in docs here
https://github.com/all-contributors/all-contributors/blob/master/docs/emoji-key.md
tenshiAMD
changed the title
research contribution typeresearch and promotion contribution types
|
@all-contributors add @201b153 for code |
|
I've put up a pull request to add @201b153! 🎉 |
|
🎉 This PR is included in version 1.16.9 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
researchcontribution key is not recognized #399What: Adding new keywords to parse-comment.js
Checklist:
Bot Usage