Merge pull request #52 from alkem-io/server-4401-ingest-space-feedback

rename env var to RABBITMQ_EVENT_BUS_EXCHANGE
alkem-io · Aug 28, 2024 · e79b5d9 · e79b5d9
2 parents ef3f5ad + 9dcd4ef
commit e79b5d9
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 5 deletions.
diff --git a/.env.default b/.env.default
@@ -4,7 +4,7 @@ RABBITMQ_PASSWORD=alkemio!
 RABBITMQ_PORT=5672
 RABBITMQ_INGEST_SPACE_QUEUE=virtual-contributor-ingest-space
 RABBITMQ_INGEST_SPACE_RESULT_QUEUE=virtual-contributor-ingest-space-result
-RABBITMQ_EXCHANGE=event-bus
+RABBITMQ_EVENT_BUS_EXCHANGE=event-bus
 
 API_ENDPOINT_PRIVATE_GRAPHQL='http://localhost:3000/api/private/non-interactive/graphql'
 AUTH_ORY_KRATOS_PUBLIC_BASE_URL=http://localhost:3000/ory/kratos/public

diff --git a/src/event.bus/connection.ts b/src/event.bus/connection.ts
@@ -49,7 +49,7 @@ export class Connection {
       port: this.getEnvValue('RABBITMQ_PORT'),
       incomingQueue: this.getEnvValue('RABBITMQ_INGEST_SPACE_QUEUE'),
       outgoingQueue: this.getEnvValue('RABBITMQ_INGEST_SPACE_RESULT_QUEUE'),
-      exchange: this.getEnvValue('RABBITMQ_EXCHANGE'),
+      exchange: this.getEnvValue('RABBITMQ_EVENT_BUS_EXCHANGE'),
     };
   }
 

diff --git a/src/index.ts b/src/index.ts
@@ -9,9 +9,6 @@ import { embedSpace } from './space.embed/embed.space';
   const connection = await Connection.get();
 
   connection.consume(async (event: IngestSpace) => {
-    //TODO create event class matching the one from Server
-    //maybe share them in a package
-    //publish a confifrmation
     logger.info(`Ingest invoked for space: ${event.spaceId}`);
     const resultEvent = await embedSpace(event);
     // add rety mechanism as well