IAN mention includes comment origin name #4780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning Rate limit exceeded@hero101 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 22 minutes and 17 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
WalkthroughThe pull request includes two main changes: an update to the Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (2)
package.json(1 hunks)src/domain/in-app-notification-reader/field-resolvers/in.app.notification.user.mentioned.resolver.fields.ts(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
src/domain/in-app-notification-reader/field-resolvers/in.app.notification.user.mentioned.resolver.fields.ts (1)
Pattern src/**/*.{ts,js}: Review the TypeScript/JavaScript code for NestJS best practices, dependency injection, module structure, and potential bugs.
Context Files (Do Not Review):
docs/Design.md- Design overview of the projectdocs/Pagination.md- Pagination design overviewdocs/Developing.md- Development setup overviewdocs/graphql-typeorm-usage.md- overview of GraphQL and TypeORM usage and how they are used together with NestJS in the projectdocs/database-definitions.md- guidelines for creating TypeORM entity defnitionssrc/core/error-handling/graphql.exception.filter.ts- GraphQL error handlingsrc/core/error-handling/http.exception.filter.ts- HTTP error handlingsrc/core/error-handling/rest.error.response.ts- REST error responsesrc/core/error-handling/unhandled.exception.filter.ts- Global exception handler
Guidelines:
- Our project uses global exception handlers (
UnhandledExceptionFilter), so avoid suggesting additionaltry/catchblocks unless handling specific cases. - Use NestJS latest documentation from
https://docs.nestjs.com/for reference on NestJS best practices. - Use TypeORM latest documentation from
https://typeorm.io/for reference on TypeORM best practices. - Refer to the design overview in the context files for better understanding.
🔇 Additional comments (2)
src/domain/in-app-notification-reader/field-resolvers/in.app.notification.user.mentioned.resolver.fields.ts (1)
41-45: Consider adding null checks for commentOrigin and displayName.
The code assumes payload.commentOrigin and payload.commentOrigin.displayName are always defined. Consider adding null checks to handle edge cases gracefully.
Let's verify the payload structure in the notifications library:
package.json (1)
59-59: Verify the notifications-lib version update.
The update from 0.10.0 to 0.10.1 is a patch version change. Let's verify the changes and if there's a newer version available.
✅ Verification successful
Version 0.10.1 is the latest available version of notifications-lib
The update from 0.10.0 to 0.10.1 is appropriate as:
- It's a patch version update following semver
- It's the latest version available on npm registry
- No older versions are being skipped
While the GitHub release notes are not accessible via the API, the version update itself is verified to be current and follows proper versioning practices.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check available versions and changelog for notifications-lib
# Check latest version on npm
npm view @alkemio/notifications-lib versions --json
# Check for any release notes or changelog
gh api repos/alkem-io/notifications-lib/releases/latest
Length of output: 788
...pp-notification-reader/field-resolvers/in.app.notification.user.mentioned.resolver.fields.ts
Outdated
Show resolved
Hide resolved
bobbykolev
approved these changes
Dec 12, 2024
valentinyanakiev
added a commit
that referenced
this pull request
Dec 16, 2024
* wip * moved dir to adapters * poc wingback create customer * poc wingback create customer * getEntitlements * comment added * first pass at two new modules for TemplatesManager, TemplateDefault * added templates manager to space; removed the SpaceDefaults entity (module still present until move all data to be via defaults * added templatesManager to platform * moved creating of default innovatin flow input to space defaults * back out space type on Template; tidy up Template module to use switch statements * created template applier module * tidy up naming * updated set of default template types * fixed circular dependency; moved logic for creating collaboration input to space defaults * removed loading of defaults from files for collaboration content * removed code based addition of callouts, innovation flow states * tidy up naming * added loading of default templates at platform level in to bootstrap * removed option to create new innovation flow template * added in migration: * loading in templates on bootstrap * added field for collaboration templates on templatesSet; added lookup for templatesManager * added mutation to create template from collaboration; added logic to prevent template used as default to be deleted; fixed removal of template set on template manager * initial creation of license + entitlements modules * add license into account * updated account to have license service + use that in mutations checking limits, removing notion of soft limits * ensure data is loaded properly on account for license checking * added mutation to reset the license calculations on account, including new auth privilege to be able to do so * renamed Licensing module to LicensingFramework module; trigger license reset on Account after assigning / removing license * removed usage of LicenseEngine outside of license services on space or account * renamed entitlement to licenseEntitlement as entity; first pass at migration * fixed issues in migration * fixed issues related to auth reset; tidied up loader creator imports * fixed auth cascade for templates of type post * license reset running * reset licenses on space after adding / removing license plans * removed need for license check in community; added entitlement check in roleset when adding a VC * remove auth reset when assigning / removing license plans * added License to RoleSet * added license to collaboration * tidied up retrieval of license for whiteboard; added license to collaboration in migration * fix typo; fix space spec file * fix additional tests * moved tempaltesManager to last migration in the list * fixed retrieval of template when creating collaboration * added logging * fixed bootstrap setting of templates * refactored inputCreator to do the data loading closer to usage; fixed picking up of templates; fixed bootstrap usage of templates * added ability to retrieve limits on entitlements + current usage * updated field names on entitlements * updated field names on entitlements * fixed account mutaiton logic bug * ensure that licenses are reset when assigning beta tester or vc campaign role to a user * added reset all account licenses mutation * fixed bug on space entitlements; refactored code to reduce duplication * fixed url generation for templates inside of TempaltesManager * fixed bootstrap order to create forum earlier * ensure collaboration creation on template provides some defaults for callouts * fix deletion of templates of type post * ensure more data is defaulted inside of template service for collaboration; add setting of isTemplate field on Collaboration, and also on contained Callouts * ensure isTempalte is passed to Collaboration entity * fixed groups in bootstrap space template; updated signature for creating callout from collaboration * fixed missing field * fixed type on mutation to create from collaboration * fixed typo * fixed groups in bootstrap space template; updated signature for creating callout from collaboration * fixed missing field * fixed type on mutation to create from collaboration * fixed typo * reworked applying collaboraiton template to collaboration * improved error message in wrong type of ID passed in * fixed build * made migration last in the list * rename migration to be last * removed read check when looking up collaboration * track free / plus / premium space entitlements separately * updated migration order * removed duplicate migration * moved auth reset to mutation for applying the template to another collaboration * extend lookup of entitlement usage to cover new types * updaed license policy to reflect new entitlements; made license engine work with entitlements, not license privileges; removed license privilege (no longer relevant) * updated migration to not drop indexes already removed * fix for license reset on space * added license policy rule for free space credential * ensure license entitlements are reset as part of the bootstrap * fixed typo * extended reset all to include resetting licenses on accounts + AI server; moved migration to be last * Address pr comment * Address PR feedback * Address PR comment * Address PR comments * Address PR comments * Address PR comment Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Improved types & naming * Address PR comments * Fixed switch-case logic in entitlements * Converge entitlements schema * Remove unused AuthorizationPrivilege * pass in spaceID on space authorization as reload the entity * initial rework of the space authorization to clean up logic so that the Space does not know about the parent account authorization * removed privileges on space that are no longer used there * minor tidy up * fixed logic check: space auth does need license entitlements * renamed the two ways for assigning entitlements * fix compilation: * renaming; code setup * take rabbit suggestion * simplify usage of wingback api setup * added flag to be able to disable wingback * fix build * fix build * fix build * TypeОRM default timezone to be UTC (#4732) * typeorm default timezone to be UTC * timezone read from the config * Added comment about default timezone --------- Co-authored-by: Neil Smyth <[email protected]> Co-authored-by: Valentin Yanakiev <[email protected]> * In-app notifications (#4760) * wip * wip * wip * wip * wip * handled empty arrays * fix for new member notification * update state mutation * rename * wip * wip * wip * wip * connection to remote service * wip * new fields * typeorm default timezone to be UTC * timezone read from the config * return sorted result by time triggered * category is the proper type * commentUrl on user mentioned * graphql enums redefined * notifications limited to beta testers only * fixed tests * renamed migrations to be on top * version bump * timezone changes reverted * timezone changes reverted from config * update state authorization * removed notificationsAll query * redundant code * reviewer suggestions * getAgent -> getAgentOrFail * first set of review changes * improved updating state * introducing mixin to avoid CD * removed unused extends from mixin * added mixin for other concrete classes --------- Co-authored-by: Svetoslav <[email protected]> Co-authored-by: bobbykolev <[email protected]> * Async invoke all engines ingest (#4766) * Async invoke all engines ingest * Reviewer suggestions * Revert unused code * notification dates properly serialized * dataloader output order must match key order (#4770) * Propagate anonymousReadAccess from parentAuthorization for Space * dataloader can now resolve to null for nullable fields * Fixed imports * proper return type * Update src/services/external/wingback/wingback.manager.ts Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Auto stash before merge of "wingback" and "origin/wingback" * Update src/platform/licensing/wingback-subscription/licensing.wingback.subscription.service.spec.ts Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * fixed comments / test issue * IAN mention includes comment origin name (#4780) * mention includes comment origin name * package version bump * added correct description to the field * New callouts to be on top (#4781) * introduce AlkemioVirtualContributorEngine for OpenAI generic and assistant engines * update quickstart-services * add powerpoint mimetypes (#4784) * 7327 Don't allow nameIds on createSubspaceInput (#4785) Co-authored-by: Valentin Yanakiev <[email protected]> * correct contributor data loader --------- Co-authored-by: Svetoslav <[email protected]> Co-authored-by: Neil Smyth <[email protected]> Co-authored-by: Neil Smyth <[email protected]> Co-authored-by: Carlos Cano <[email protected]> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: bobbykolev <[email protected]> Co-authored-by: Evgeni Dimitrov <[email protected]> Co-authored-by: Vladimir Aleksiev <[email protected]> Co-authored-by: Vladimir Aleksiev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
commentOriginNamefor in-app notifications, enhancing the information available in notifications.Chores
@alkemio/notifications-libdependency from0.10.0to0.10.1.