fix subspace-admin credential removal + small refactor

[valentinyanakiev]

• optimized a redundant check on figuring out whether the user is a subspace-admin (done with one DB call)
• fixed a typo
• fixed wrongly passed roleSetId to credential removal logic

Summary by CodeRabbit

• New Features

  • Improved role management functionality, enhancing the efficiency of role set operations.

• Bug Fixes

  • Corrected the logic for removing contributors from roles, ensuring proper handling of admin roles.

• Refactor

  • Renamed method for clarity and simplified return statements for better performance.

[coderabbitai]

Warning

Rate limit exceeded

@techsmyth has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 15 minutes and 22 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 5eefcdd and 59aca63.

Walkthrough

The pull request introduces modifications to the RoleSetService class in src/domain/access/role-set/role.set.service.ts. Key changes include the addition of an import statement for Not from typeorm, a rename of the removeContributorToImplicitRole method to removeContributorFromImplicitRole, and a simplification of the getPeerRoleSets method's return statement. Additionally, the removeUserFromRole method has been updated to improve the handling of contributor removal from parent role sets.

Changes

File Path	Change Summary
src/domain/access/role-set/role.set.service.ts	- Added import for Not from typeorm. - Renamed method removeContributorToImplicitRole to removeContributorFromImplicitRole. - Simplified return statement in getPeerRoleSets to use Not(childRoleSet.id). - Updated removeUserFromRole method to check for other admin roles before removal.

Possibly related PRs

• Cleanup roles indexes #4581: The changes in this PR involve database schema modifications related to roles, which may indirectly connect to the role management functionalities in the main PR.
• Fix migration #4584: This PR includes a migration script that restructures role and role set management in the database, directly relating to the changes made in the RoleSetService class in the main PR.

Suggested reviewers

• ccanos

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[Comoque1]

When a user has been only a member of space/subspace/subsubspace and leave them, he successfully leaves the communities.
When a user has been an admin and a member of a subspace and leave all journeys he still has subspace-admin credentials(even, after it has been removed from the community)

[techsmyth]

Actually this must remain the parent role set, as that is where the "subspaceAdmin" role makes sense.

So the logic is that if the user is no longer an admin in the subspace, and that was the last admin role, then the user is no longer a "subspace admin" in the parent space