-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Server 4401 ingest space feedback #4468
Conversation
add calculated field status on VC add VC updated subscription add event handler trough CQRS for ingest space result
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Main concern is the linkage back from AI Server to VC, to be chatted through...
src/domain/community/virtual-contributor/dto/virtual.contributor.updated.subscription.args.ts
Outdated
Show resolved
Hide resolved
src/domain/community/virtual-contributor/virtual.contributor.resolver.subscriptions.ts
Outdated
Show resolved
Hide resolved
src/domain/community/virtual-contributor/virtual.contributor.resolver.subscriptions.ts
Outdated
Show resolved
Hide resolved
src/domain/community/virtual-contributor/virtual.contributor.resolver.subscriptions.ts
Outdated
Show resolved
Hide resolved
src/services/infrastructure/event-bus/messages/ingest.space.result.event.ts
Show resolved
Hide resolved
src/services/infrastructure/event-bus/messages/ingest.space.result.event.ts
Show resolved
Hide resolved
src/services/ai-server/ai-persona-service/ai.persona.service.interface.ts
Outdated
Show resolved
Hide resolved
define handlers for incomming events only add more logs
…io/server into server-4401-ingest-space-feedback
change bodyOfKnowledgeLastUpdated to be Date | null instead of undefined
@techsmyth @hero101 We all dislike the dependency of the AiServer on the the VC repository (or some other part of the collaboration server), but I can't think of a way around it. This will need reworking when we split out the AiServer anyway. Ignoring this I think I've addressed all comments and the implementation is complete. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Understood re linkage back from AI server to collaboration server. To be addressed later.
…io/server into server-4401-ingest-space-feedback
@valeksiev One note I just noticed, maybe it's okay, maybe you can't/don't want to do anything about it, |
Describe the background of your pull request
Fixes: #4401