Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix url encoding #62

Merged
merged 5 commits into from
Sep 1, 2017
Merged

fix url encoding #62

merged 5 commits into from
Sep 1, 2017

Conversation

baiyubin
Copy link
Contributor

变更内容

  • 修复：URL中特殊字符的编码问题

@coveralls
Copy link

coveralls commented Aug 30, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.03%) to 90.719% when pulling 1d3faad on fix-sign-url into 2d4691a on master.

@coveralls
Copy link

coveralls commented Aug 30, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.02%) to 90.731% when pulling f673642 on fix-sign-url into 2d4691a on master.

@coveralls
Copy link

coveralls commented Aug 30, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.2%) to 90.952% when pulling 5ffa6d2 on fix-sign-url into 2d4691a on master.

1 similar comment
@coveralls
Copy link

coveralls commented Aug 30, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.2%) to 90.952% when pulling 5ffa6d2 on fix-sign-url into 2d4691a on master.

@coveralls
Copy link

coveralls commented Aug 30, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.2%) to 90.952% when pulling 5ffa6d2 on fix-sign-url into 2d4691a on master.

abo969
abo969 reviewed Aug 31, 2017
View reviewed changes
oss/conn.go
object = url.QueryEscape(object)
}
object = url.QueryEscape(object)
object = strings.Replace(object, "+", "%20", -1)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

object j= url.QueryEscape(object)
这句执行后应该能保证现在的+就是由之前的空格变来的吧。而之前的+已经变成了%2B。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是的，QueryEscape 会把空格变成+，原来的+会变成%2B。

abo969
abo969 reviewed Aug 31, 2017
View reviewed changes
Copy link

@abo969 abo969 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+2

yami
yami reviewed Aug 31, 2017
View reviewed changes
.travis.yml
- 1.5
- 1.6
- 1.7
- 1.8
Copy link
Contributor

@yami yami Aug 31, 2017 •
edited by baiyubin
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我们的回归测试里，有专门对go1.8做吗？

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

‘GO1.8是这次新加到回归测试里面的。

@coveralls
Copy link

coveralls commented Aug 31, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.2%) to 90.952% when pulling 857f13b on fix-sign-url into 2d4691a on master.

@baiyubin baiyubin merged commit 1354553 into master Sep 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abo969 abo969 abo969 left review comments

@yami yami yami left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@baiyubin @coveralls @yami @abo969 @baiyubin2020