improve environment variable implements #900
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JacksonTian
force-pushed
the
env
branch
2 times, most recently
from
d460e2d
to
f6c47bd
Compare
yndu13
reviewed
Jun 13, 2024
| } | ||
| } | ||
|
|
||
| public static void setEnvironmentAccessKeyId(String environmentAccessKeyId) { |
There was a problem hiding this comment.
这种方式还不能删掉，用户是可能会用到的，可以先置为弃用，标注弃用时间。时间到期再删。
| @@ -1,48 +0,0 @@ | |||
| package com.aliyuncs.utils; | |||
There was a problem hiding this comment.
这种方式还不能删掉，用户是可能会用到的，可以先置为弃用，标注弃用时间。时间到期再删。
| @@ -16,7 +16,7 @@ public DefaultCredentialsProvider() throws ClientException { | |||
| defaultProviders.add(new SystemPropertiesCredentialsProvider()); | |||
| defaultProviders.add(new EnvironmentVariableCredentialsProvider()); | |||
| defaultProviders.add(new ProfileCredentialsProvider()); | |||
| String roleName = AuthUtils.getEnvironmentECSMetaData(); | |||
There was a problem hiding this comment.
需要保留和兼容之前的get方式，因为AuthUtils有对应的set方法
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #900 +/- ##
============================================
- Coverage 89.98% 89.92% -0.07%
+ Complexity 1654 1638 -16
============================================
Files 124 124
Lines 4734 4705 -29
Branches 544 543 -1
============================================
- Hits 4260 4231 -29
- Misses 347 348 +1
+ Partials 127 126 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.