Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repair follow_symlinks bug in old aiohttp version #406

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

NKcqx
Copy link
Collaborator

@NKcqx NKcqx commented Mar 6, 2024

Why are these changes needed?

We use "static" path in aiohttp, however, when follow_symlinks is set to true, a path reverse breakdown problem will exist in the static directory file, for example:
image

This has been fixed in aiohttp>=3.9.3

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@NKcqx NKcqx added the bug Something isn't working label Mar 6, 2024
@NKcqx NKcqx self-assigned this Mar 6, 2024
@NKcqx NKcqx merged commit 6f348a6 into dev/2.2.0 Mar 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants