kinesis_stream: Don't mark kstreams changed when no encryption acti…

…ons taken (ansible-collections#27) * fix: Don't mark kstreams `changed` when no encryption actions taken Fixes ansible/ansible#65928 * doc: add changelog fragment * Move disable_stream_encryption test to integration test * Update descriptions/fetch calls to still run on check_mode * use standard helpers to convert tags to/from boto3 format * use camel_dict_to_snake_dict helper * use standard compare_aws_tags helper * Fix tag handling and use standard helpers * Format results and add tags when manipulating encryption settings * Move kinesis_stream tests over to just integration tests * changelog * lint Co-authored-by: Tyler Schwend <[email protected]> Co-authored-by: Mark Chappell <[email protected]>
alinabuzachis · Mar 31, 2021 · ffeab00 · ffeab00
1 parent d5bd6dc
commit ffeab00
Show file tree

Hide file tree

Showing 6 changed files with 191 additions and 361 deletions.
diff --git a/changelogs/fragments/23-kinesis_stream-changed.yml b/changelogs/fragments/23-kinesis_stream-changed.yml
@@ -0,0 +1,5 @@
+minor_changes:
+- kinesis_stream - now returns tags consistently (https://github.com/ansible-collections/community.aws/pull/27).
+- kinesis_stream - now returns changed more accurately (https://github.com/ansible-collections/community.aws/pull/27).
+- kinesis_stream - return values are now the same format when working with both encrypted and un-encrypted streams (https://github.com/ansible-collections/community.aws/pull/27).
+- kinesis_stream - check_mode is now based on the live settings rather than comparisons with a hard coded/fake stream definition (https://github.com/ansible-collections/community.aws/pull/27).
diff --git a/changelogs/fragments/27-kinesis_stream-do-not-mark-as-changed-no-enc-actions.yaml b/changelogs/fragments/27-kinesis_stream-do-not-mark-as-changed-no-enc-actions.yaml
@@ -0,0 +1,2 @@
+bugfixes:
+  - kinesis_stream - fixed issue where streams get marked as changed even if no encryption actions were necessary (https://github.com/ansible/ansible/issues/65928).
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		bugfixes:
		- kinesis_stream - fixed issue where streams get marked as changed even if no encryption actions were necessary (https://github.com/ansible/ansible/issues/65928).