fix: ansible kinesis stream paginated shards bug (ansible-collections#93

) * fix: ansible kinesis stream paginated shards bug * only set shardid params when more shards * add changelog fragment
alinabuzachis · Dec 1, 2020 · e331bb8 · e331bb8
1 parent 1654d5c
commit e331bb8
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/changelogs/fragments/93-kinesis_stream-get-more-shards-resolve.yml b/changelogs/fragments/93-kinesis_stream-get-more-shards-resolve.yml
@@ -0,0 +1,2 @@
+bugfixes:
+- kinesis_stream - fixes issue where kinesis streams with > 100 shards get stuck in an infinite loop (https://github.com/ansible-collections/community.aws/pull/93)
diff --git a/plugins/modules/kinesis_stream.py b/plugins/modules/kinesis_stream.py
@@ -364,6 +364,8 @@ def find_stream(client, stream_name, check_mode=False):
                 )
                 shards.extend(results.pop('Shards'))
                 has_more_shards = results['HasMoreShards']
+                if has_more_shards:
+                    params['ExclusiveStartShardId'] = shards[-1]['ShardId']
             results['Shards'] = shards
             num_closed_shards = len([s for s in shards if 'EndingSequenceNumber' in s['SequenceNumberRange']])
             results['OpenShardsCount'] = len(shards) - num_closed_shards
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		bugfixes:
		- kinesis_stream - fixes issue where kinesis streams with > 100 shards get stuck in an infinite loop (https://github.com/ansible-collections/community.aws/pull/93)