Skip to content

Commit

Permalink
Fix missing no_log=True.
Browse files Browse the repository at this point in the history
  • Loading branch information
felixfontein committed Mar 13, 2021
1 parent 6ea4eb0 commit 8d0fb0f
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 3 deletions.
4 changes: 4 additions & 0 deletions changelogs/fragments/475-no_log-missing.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
security_fixes:
- "aws_direct_connect_virtual_interface - mark the ``authentication_key`` parameter as ``no_log`` to avoid accidental leaking of secrets in logs (https://github.com/ansible-collections/community.aws/pull/475)."
- "sts_assume_role - mark the ``mfa_token`` parameter as ``no_log`` to avoid accidental leaking of secrets in logs (https://github.com/ansible-collections/community.aws/pull/475)."
- "sts_session_token - mark the ``mfa_token`` parameter as ``no_log`` to avoid accidental leaking of secrets in logs (https://github.com/ansible-collections/community.aws/pull/475)."
2 changes: 1 addition & 1 deletion plugins/modules/aws_direct_connect_virtual_interface.py
Original file line number Diff line number Diff line change
Expand Up @@ -484,7 +484,7 @@ def main():
name=dict(),
vlan=dict(type='int', default=100),
bgp_asn=dict(type='int', default=65000),
authentication_key=dict(),
authentication_key=dict(no_log=True),
amazon_address=dict(),
customer_address=dict(),
address_type=dict(),
Expand Down
2 changes: 1 addition & 1 deletion plugins/modules/sts_assume_role.py
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ def main():
external_id=dict(required=False, default=None),
policy=dict(required=False, default=None),
mfa_serial_number=dict(required=False, default=None),
mfa_token=dict(required=False, default=None)
mfa_token=dict(required=False, default=None, no_log=True)
)

module = AnsibleAWSModule(argument_spec=argument_spec)
Expand Down
2 changes: 1 addition & 1 deletion plugins/modules/sts_session_token.py
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ def main():
argument_spec = dict(
duration_seconds=dict(required=False, default=None, type='int'),
mfa_serial_number=dict(required=False, default=None),
mfa_token=dict(required=False, default=None),
mfa_token=dict(required=False, default=None, no_log=True),
)

module = AnsibleAWSModule(argument_spec=argument_spec)
Expand Down

0 comments on commit 8d0fb0f

Please sign in to comment.