More no_log changes (ansible-collections#471)

* More no_log changes * changelog
alinabuzachis · Mar 12, 2021 · 527b5cd · 527b5cd
1 parent f39d1ec
commit 527b5cd
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/changelogs/fragments/471-no_log.yml b/changelogs/fragments/471-no_log.yml
@@ -0,0 +1,2 @@
+security_fixes:
+- aws_secret - flag the ``secret`` paramter as containing sensitive data which shouldn't be logged (https://github.com/ansible-collections/community.aws/pull/471).
diff --git a/plugins/modules/aws_secret.py b/plugins/modules/aws_secret.py
@@ -334,7 +334,7 @@ def main():
             'description': dict(default=""),
             'kms_key_id': dict(),
             'secret_type': dict(choices=['binary', 'string'], default="string"),
-            'secret': dict(default=""),
+            'secret': dict(default="", no_log=True),
             'tags': dict(type='dict', default={}),
             'rotation_lambda': dict(),
             'rotation_interval': dict(type='int', default=30),

diff --git a/plugins/modules/s3_sync.py b/plugins/modules/s3_sync.py
@@ -497,7 +497,7 @@ def main():
         mode=dict(choices=['push'], default='push'),
         file_change_strategy=dict(choices=['force', 'date_size', 'checksum'], default='date_size'),
         bucket=dict(required=True),
-        key_prefix=dict(required=False, default=''),
+        key_prefix=dict(required=False, default='', no_log=False),
         file_root=dict(required=True, type='path'),
         permission=dict(required=False, choices=['private', 'public-read', 'public-read-write', 'authenticated-read',
                                                  'aws-exec-read', 'bucket-owner-read', 'bucket-owner-full-control']),
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		security_fixes:
		- aws_secret - flag the ``secret`` paramter as containing sensitive data which shouldn't be logged (https://github.com/ansible-collections/community.aws/pull/471).