Skip to content

Commit

Permalink
Final removal of original boto SDK (ansible-collections#898)
Browse files Browse the repository at this point in the history
[Breaking Change] Final removal of original boto SDK

SUMMARY

Remove old boto based inventory script
Clean up requirements
Clean up random comments in docs/comments

ISSUE TYPE

Feature Pull Request

COMPONENT NAME
scripts/inventory/ec2.py
requirements.txt
test-requirements.txt
tests/integration/requirements.txt
tests/unit/requirements.txt
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis <None>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@00037be
  • Loading branch information
tremble authored and goneri committed Sep 21, 2022
1 parent c7fcf1e commit 71fd15c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion plugins/modules/route53.py
Original file line number Diff line number Diff line change
Expand Up @@ -413,7 +413,7 @@ def get_zone_id_by_name(route53, module, zone_name, want_private, want_vpc_id):

if private_zone == want_private and zone['Name'] == zone_name:
if want_vpc_id:
# NOTE: These details aren't available in other boto methods, hence the necessary
# NOTE: These details aren't available in other boto3 methods, hence the necessary
# extra API call
hosted_zone = route53.get_hosted_zone(aws_retry=True, Id=zone_id)
if want_vpc_id in [v['VPCId'] for v in hosted_zone['VPCs']]:
Expand Down

0 comments on commit 71fd15c

Please sign in to comment.