Skip to content

Commit

Permalink
Type conversion issue for creating read replicas (ansible-collections…
Browse files Browse the repository at this point in the history
…#229)

* Type conversion issue for creating read replicas
* Added changelog snippet
* Updated tests

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@cd938b2
  • Loading branch information
tombenninger authored and alinabuzachis committed Sep 9, 2022
1 parent 6ee4298 commit 359f7da
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions plugins/modules/rds_instance.py
Original file line number Diff line number Diff line change
Expand Up @@ -842,8 +842,10 @@ def get_parameters(client, module, parameters, method_name):
if parameters.get('ProcessorFeatures') == [] and not method_name == 'modify_db_instance':
parameters.pop('ProcessorFeatures')

if method_name == 'create_db_instance' and parameters.get('Tags'):
parameters['Tags'] = ansible_dict_to_boto3_tag_list(parameters['Tags'])
if method_name == 'create_db_instance' or method_name == 'create_db_instance_read_replica':
if parameters.get('Tags'):
parameters['Tags'] = ansible_dict_to_boto3_tag_list(parameters['Tags'])

if method_name == 'modify_db_instance':
parameters = get_options_with_changing_values(client, module, parameters)

Expand Down

0 comments on commit 359f7da

Please sign in to comment.