Various safety improvements #55
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sprintf is not a safe function to call: it will potentially write beyond the end of a buffer. It can be replaced with snprintf to prevent buffer overflow.
tolower can return the input, which is potentially signed. Saving as
an unsigned char will prevent a compiler warning (Below from GCC
12.2):
reg.c: In function ‘reg_putraw’:
reg.c:21:18: warning: array subscript [-128, 255] is outside array bounds of ‘char *[256]’ [-Warray-bounds]
21 | free(bufs[tolower(c)]);
| ~~~~^~~~~~~~~~~~
reg.c:6:14: note: while referencing ‘bufs’
6 | static char *bufs[256];
| ^~~~
reg.c:22:13: warning: array subscript [-128, 255] is outside array bounds of ‘char *[256]’ [-Warray-bounds]
22 | bufs[tolower(c)] = buf;
| ~~~~^~~~~~~~~~~~
reg.c:6:14: note: while referencing ‘bufs’
6 | static char *bufs[256];
| ^~~~
strcpy() does not check the size of the destination buffer, and may cause buffer overflows. Replace usages of strcpy with safer code.
|
what's it take to get this merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Three patches are included which replace functions which are commonly a cause of buffer overflows.
Read the commit message of each patch for description.