Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MICRO-26: Rework to match new architecture #228

Merged
merged 4 commits into from
Nov 13, 2023
Merged

MICRO-26: Rework to match new architecture #228

merged 4 commits into from
Nov 13, 2023

Conversation

kai-nguyen-aligent
Copy link
Contributor

@kai-nguyen-aligent kai-nguyen-aligent commented Nov 10, 2023 •
edited
Loading

This plugin now only does 2 things via API calls:

  1. Register service with Magento
  2. De-register service with Magento

This plugin can be used for both normal service and the client service (the webapp itself)

  • When we register a normal service, we will need to add the permissions and can omit the appUrl.
  • WHen we register a webapp, we will need the appUrl and ignore the permissions.

@kai-nguyen-aligent kai-nguyen-aligent requested review from gowrizrh and a team as code owners November 10, 2023 05:31
tvhees
tvhees approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@tvhees tvhees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good Kai.

@kai-nguyen-aligent kai-nguyen-aligent merged commit 12d9fc7 into main Nov 13, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tvhees tvhees tvhees approved these changes

@TheOrangePuff TheOrangePuff Awaiting requested review from TheOrangePuff

@gowrizrh gowrizrh Awaiting requested review from gowrizrh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kai-nguyen-aligent @tvhees