Merge pull request #1058 from aligent/chore/upgrade-following-node16-…

…module

Upgrade template following node16 module

README.md

@@ -8,11 +8,11 @@ The monorepo workspace is managed using [Nx.](https://nx.dev)
 
 ### Setup
 
-2. Update application name in `package.json`. It's recommend to have the name in the format of: `@<brand-name>-int/<from>-<to>`. Eg: `@aligent-int/erp-ecomm`
+1. Update application name in `package.json`. It's recommend to have the name in the format of: `@<brand-name>-int/<from>-<to>`. Eg: `@aligent-int/erp-ecomm`
 
-3. Update brand name to `nx.json`. The naming convention for this is: `<brand-name>-int`. Just be mindful about the length of service name. Eg: `alg-int`
+2. Update brand name in `nx.json`. The naming convention for this is: `<brand-name>-int`. Just be mindful about the length of service name. Eg: `alg-int`
 
-4. Install dependencies: `npm ci`
+3. Install dependencies: `npm ci`
 
 ### Working with services
 
@@ -85,6 +85,8 @@ Below are some example of general Nx. commands. For more information, check out
 
 ## Notes:
 
+- The `tsconfig.base.json` file extends `@tsconfig/node20` and `@tsconfig/strictest` packages. Please note that there are settings which is not shown in that file but still applied. For more information on those settings, visit https://github.com/tsconfig/bases.
+
 - This template is package manager agnostic. To use other package manager, install them by enabling [corepack](https://pnpm.io/installation#using-corepack).
 
 ## Under development

nx.json

@@ -31,7 +31,7 @@
             ],
             "cache": true
         },
-        "@nx/vite:test": {
+        "test": {
             "inputs": ["default", "^production"],
             "cache": true
         }

package.json

@@ -7,8 +7,8 @@
     "test:all": "nx run-many -t test --coverage",
     "lint": "nx affected -t lint",
     "lint:all": "nx run-many -t lint",
-    "format": "nx format:check",
-    "format:write": "nx format:write",
+    "format": "prettier . --check",
+    "format:write": "prettier . --write",
     "check-types": "nx affected -t check-types",
     "check-types:all": "nx run-many -t check-types",
     "prepare": "[ -d .git ] && git config core.hooksPath '.git-hooks' || true"
@@ -48,8 +48,8 @@
     "serverless": "^3.38.0",
     "serverless-esbuild": "^1.50.1",
     "serverless-step-functions": "^3.21.0",
-    "ts-node": "10.9.2",
     "tslib": "^2.6.2",
+    "tsx": "^4.17.0",
     "typescript": "~5.3.3",
     "vite": "~4.5.3",
     "vite-tsconfig-paths": "~4.3.2",

tools/serverless-plugin/src/generators/service/general-files/.eslintrc.json.template

@@ -1,18 +1,4 @@
 {
     "extends": ["../../.eslintrc.json"],
-    "ignorePatterns": ["!**/*"],
-    "overrides": [
-        {
-            "files": ["*.ts", "*.tsx", "*.js", "*.jsx"],
-            "rules": {}
-        },
-        {
-            "files": ["*.ts", "*.tsx"],
-            "rules": {}
-        },
-        {
-            "files": ["*.js", "*.jsx"],
-            "rules": {}
-        }
-    ]
+    "ignorePatterns": ["!**/*"]
 }

tools/serverless-plugin/src/generators/service/general-files/tsconfig.json.template

@@ -4,7 +4,7 @@
         "esModuleInterop": true
     },
     "include": [
-        "vite.config.ts",
+        "vite.config.mts",
         "../../libs/**/src/index.ts",
         "src/**/*.ts",
         "**/*.test.ts"

tools/serverless-plugin/src/generators/service/general-files/vite.config.ts.template → tools/serverless-plugin/src/generators/service/general-files/vite.config.mts.template

@@ -1,5 +1,5 @@
 import { defineConfig, mergeConfig } from 'vitest/config';
-import { viteBaseConfig } from '../../vite.config.base';
+import { viteBaseConfig } from '../../vite.config.base.mjs';
 
 export default mergeConfig(
     viteBaseConfig,

tools/serverless-plugin/src/generators/service/notification-files/.eslintrc.json.template

@@ -1,18 +1,4 @@
 {
     "extends": ["../../.eslintrc.json"],
-    "ignorePatterns": ["!**/*"],
-    "overrides": [
-        {
-            "files": ["*.ts", "*.tsx", "*.js", "*.jsx"],
-            "rules": {}
-        },
-        {
-            "files": ["*.ts", "*.tsx"],
-            "rules": {}
-        },
-        {
-            "files": ["*.js", "*.jsx"],
-            "rules": {}
-        }
-    ]
+    "ignorePatterns": ["!**/*"]
 }

tools/serverless-plugin/src/generators/service/notification-files/tsconfig.json.template

@@ -4,7 +4,7 @@
         "esModuleInterop": true
     },
     "include": [
-        "vite.config.ts",
+        "vite.config.mts",
         "../../libs/**/src/index.ts",
         "src/**/*.ts",
         "**/*.test.ts"

tools/serverless-plugin/src/generators/service/notification-files/vite.config.ts.template → tools/serverless-plugin/src/generators/service/notification-files/vite.config.mts.template

@@ -1,5 +1,5 @@
 import { defineConfig, mergeConfig } from 'vitest/config';
-import { viteBaseConfig } from '../../vite.config.base';
+import { viteBaseConfig } from '../../vite.config.base.mjs';
 
 export default mergeConfig(
     viteBaseConfig,

tools/serverless-plugin/src/generators/service/schema.json

@@ -27,5 +27,5 @@
             }
         }
     },
-    "required": [ "brand", "name" ]
+    "required": ["brand", "name"]
 }

tools/serverless-plugin/tsconfig.json

@@ -1,14 +1,7 @@
 {
     "extends": "../../tsconfig.base.json",
     "compilerOptions": {
-        "module": "Node16",
-        "forceConsistentCasingInFileNames": true,
-        "strict": true,
-        "noImplicitOverride": true,
-        "noPropertyAccessFromIndexSignature": true,
-        "noImplicitReturns": true,
-        "noFallthroughCasesInSwitch": true,
-        "types": ["vitest"]
+        "esModuleInterop": true
     },
     "files": [],
     "include": [],

tools/serverless-plugin/tsconfig.lib.json

@@ -2,7 +2,6 @@
     "extends": "./tsconfig.json",
     "compilerOptions": {
         "outDir": "../../dist/out-tsc",
-        "declaration": true,
         "types": ["node"]
     },
     "include": [

tools/serverless-plugin/tsconfig.spec.json

@@ -5,7 +5,7 @@
         "types": ["vitest/globals", "vitest/importMeta", "vite/client", "node"]
     },
     "include": [
-        "vite.config.ts",
+        "vite.config.mts",
         "src/**/*.test.ts",
         "src/**/*.spec.ts",
         "src/**/*.test.tsx",

tools/serverless-plugin/vite.config.ts → tools/serverless-plugin/vite.config.mts

@@ -1,5 +1,5 @@
 import { defineConfig, mergeConfig } from 'vitest/config';
-import { viteBaseConfig } from '../../vite.config.base';
+import { viteBaseConfig } from '../../vite.config.base.mjs';
 
 export default mergeConfig(
     viteBaseConfig,

tsconfig.base.json

@@ -8,10 +8,7 @@
         "emitDecoratorMetadata": true,
         "experimentalDecorators": true,
         "importHelpers": true,
-        "target": "es2015",
-        "module": "esnext",
-        "lib": ["es2020", "dom"],
-        "skipLibCheck": true,
+        "lib": ["es2022", "dom"],
         "skipDefaultLibCheck": true,
         "baseUrl": ".",
         "paths": {