Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BEG-160 | Created a fix to get the store URL for the recache request #17

Merged
merged 2 commits into from
Apr 12, 2024

Conversation

ryanjehan-aligent
Copy link

We are getting the cached URL when products are assigned to multiple stores.

I updated the logic to use the store URL.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aligent-lturner
Copy link
Collaborator

@ryanjehan-aligent I really don't know why the actual results don't show up in the check output, but this is currently failing the phpcs check due to previous changes on the files in question. I ran it locally and got these results:

FILE: /app/app/code/Aligent/Prerender/Model/Mview/View/Attribute/CatalogProductLinkSubscription.php
------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
------------------------------------------------------------------------------------------------------
 171 | WARNING | [x] Multi-line function call not indented correctly; expected 12 spaces but found 16
 172 | WARNING | [x] Multi-line function call not indented correctly; expected 12 spaces but found 16
 185 | WARNING | [x] Multi-line function call not indented correctly; expected 8 spaces but found 12
------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------


FILE: /app/app/code/Aligent/Prerender/Model/Url/GetUrlsForCategories.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
 37 | WARNING | @param is not found for one or more params in method annotation
--------------------------------------------------------------------------------


FILE: /app/app/code/Aligent/Prerender/Model/Url/GetUrlsForProducts.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
 37 | WARNING | @param is not found for one or more params in method annotation
--------------------------------------------------------------------------------

@ryanjehan-aligent
Copy link
Author

Hi @aligent-lturner,

I did not get the CS issues for code/Aligent/Prerender/Model/Mview/View/Attribute/CatalogProductLinkSubscription.php

image

I have updated the other files.

@aligent-lturner aligent-lturner merged commit daf3633 into main Apr 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants