Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add ecs tag permission to pipe #1354

Merged
merged 2 commits into from
May 7, 2024
Merged

feat: add ecs tag permission to pipe #1354

merged 2 commits into from
May 7, 2024

Conversation

TheOrangePuff
Copy link
Contributor

Description of the proposed changes

  • Adds tag permissions to ECS deployment pipeline. This way when the pipe triggers a deployment to ECS, if the task requires a tag it has permission to add it.

Notes to reviewers

🛈 When you've finished leaving feedback, please add a final comment to the PR tagging the author, letting them know that you have finished leaving feedback

@TheOrangePuff TheOrangePuff requested review from AdamJHall, gowrizrh and a user May 3, 2024 05:13
gowrizrh
gowrizrh approved these changes May 3, 2024
View reviewed changes
Copy link
Contributor

@gowrizrh gowrizrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 🚀 🚀

@TheOrangePuff TheOrangePuff merged commit c0d4867 into main May 7, 2024
1 check passed
@TheOrangePuff TheOrangePuff mentioned this pull request May 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gowrizrh gowrizrh gowrizrh approved these changes

@AdamJHall AdamJHall Awaiting requested review from AdamJHall

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TheOrangePuff @gowrizrh