Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO-1543: call unsafeUnwrap to pass the secret key to the env #1101

Conversation

krishanthisera
Copy link
Contributor


Description of the proposed changes

  • Using .toString() on Secrets seems no longer accepted without calling .unsafeUnwrap() first.
  • Export prerender Fargate option interface

Screenshots (if applicable)

  • N/A

Other solutions considered (if any)

Notes to PR author

⚠️ Please make sure the changes adhere to the guidelines mentioned here

Notes to reviewers

🛈 When you've finished leaving feedback, please add a final comment to the PR tagging the author, and letting them know that you have finished leaving feedback

@krishanthisera krishanthisera force-pushed the fix/DO-1543_prerender_fargate_secrets_unwrap branch from 936b17a to cc9ced9 Compare October 5, 2023 01:22
Copy link
Contributor

@TheOrangePuff TheOrangePuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@TheOrangePuff TheOrangePuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@krishanthisera krishanthisera merged commit ddbcd17 into feature/DO-1285-upgrade-cdk Oct 5, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants