Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO-1486: Include CODE_OF_CONDUCT.md and CONTRIBUTING.md files #1056

Merged
merged 3 commits into from
Oct 20, 2023

Conversation

krishanthisera
Copy link
Contributor

@krishanthisera krishanthisera commented Jun 29, 2023

Include CODE_OF_CONDUCT.md and CONTRIBUTING.md files


Description of the proposed changes

  • We shall introduce CODE_OF_CONDUCT.md and CONTRIBUTING.md files to our open-source repos
  • Fixed a tiny formatting issue in the static hosting construct which was breaking the build

Screenshots (if applicable)

  • N/A

Other solutions considered (if any)

  • M/A

Notes to PR author

⚠️ Please make sure the changes adhere to the guidelines mentioned here

Notes to reviewers

🛈 When you've finished leaving feedback, please add a final comment to the PR tagging the author, and letting them know that you have finished leaving feedback

@krishanthisera krishanthisera force-pushed the feature/DO-1486_contributing_guidelines branch from 177fe07 to 00b0baf Compare June 29, 2023 06:53
@krishanthisera krishanthisera force-pushed the feature/DO-1486_contributing_guidelines branch from 00b0baf to 558537a Compare June 29, 2023 06:57
Copy link
Contributor

@TheOrangePuff TheOrangePuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good! Just one minor comment 🙂

CONTRIBUTING.md Outdated

Below is a list of available constructs:

- [basic-auth](packages/basic-auth)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this just link to the README rather than listing the constructs? I can see myself forgetting to update this 😅

Copy link
Contributor

@TheOrangePuff TheOrangePuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@krishanthisera krishanthisera merged commit bc8b3e7 into main Oct 20, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants