Skip to content

Commit

Permalink
Merge pull request #1054 from aligent/feature/DO-1481_including_linti…
Browse files Browse the repository at this point in the history
…ng_and_formatting_checks_in_builds

 Include Linting and Formatting checks in PR builds
  • Loading branch information
krishanthisera authored Jun 23, 2023
2 parents fabadb2 + 6c2c052 commit f04189e
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 3 deletions.
4 changes: 2 additions & 2 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@

**Notes to PR author**

⚠️ Please make sure the changes are adhere to the guidelines mention [here](https://aligent.atlassian.net/wiki/spaces/AL/pages/2758836297/Development+checklist+FE+BE+INT)
⚠️ Please make sure the changes adhere to the guidelines mentioned [here](https://aligent.atlassian.net/wiki/spaces/AL/pages/2728919167/Pull+Request+guidelines)

**Notes to reviewers**

*
🛈 When you've finished leaving feedback, please add a final comment to the PR tagging the author, letting them know that you have finished leaving feedback
1 change: 1 addition & 0 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,5 @@ jobs:
node-version: 16
registry-url: https://registry.npmjs.org/
- run: npm ci
- run: npm run lint:check && npm run format:check
- run: npm run build
4 changes: 3 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,10 @@
"build": "tsc",
"prepublish": "tsc",
"lint": "eslint --ignore-path .eslintignore --ext .ts .",
"lint:check": "npm run lint",
"lint:fix": "npm run lint --fix",
"format:check": "prettier --ignore-path .prettierignore --check \"**/*.+(js|ts|json)\"",
"format": "prettier --ignore-path .prettierignore --check \"**/*.+(js|ts|json)\"",
"format:check": "npm run format",
"format:fix": "prettier --ignore-path .prettierignore --write \"**/*.+(js|ts|json)\""
},
"devDependencies": {
Expand Down

0 comments on commit f04189e

Please sign in to comment.