-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Credentials in POST #24
Conversation
@danygielow thank you for another great PR! I will take a look this evening, we have small issues in typing: https://github.com/aliev/aioauth/pull/24/checks?check_run_id=2001875113
|
Seems good with me. Note on RFC6749 Section 3.2, Token Endpoint:
|
…OST and auth header
93ed8fb
to
4049f5a
Compare
Codecov Report
@@ Coverage Diff @@
## master #24 +/- ##
==========================================
+ Coverage 99.26% 99.27% +0.01%
==========================================
Files 15 15
Lines 541 549 +8
Branches 55 56 +1
==========================================
+ Hits 537 545 +8
Misses 3 3
Partials 1 1
Continue to review full report at Codecov.
|
All seems resolved. @aliev Everything looks good to me. 👍🏼 |
for me looks great as well :) @danygielow great job thank you! approved |
client_id and client_secret can also be given via POST data. So added client_id and client_secret to Post namedtuple and trying to retrieve them via POST first. Auth Header if they were not found.
https://www.oauth.com/oauth2-servers/access-tokens/client-credentials/