HTTP Post Request Implementation #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LNK2019 STILL HERE!!! NOT FIXED...
aoqia194
commented
Apr 9, 2023
| @@ -80,7 +80,53 @@ namespace utils::http | |||
|
|
|||
| if (curl_easy_perform(curl) == CURLE_OK) | |||
| { | |||
| return {std::move(buffer)}; | |||
There was a problem hiding this comment.
This only exists because of my previous commit.
aoqia194
commented
Apr 9, 2023
src/component/io.cpp
Outdated
| scripting::script_value http_post(const gsc::function_args& args) | ||
| { | ||
| const auto url = args[0].as<std::string>(); | ||
| const auto headers = args[1].as<utils::http::headers>(); |
There was a problem hiding this comment.
This is where linker error is happening mainly. Using utils::http::headers for some reason causes that error. I've even tried just using std::unordered_map<std::string, std::string> and it causes the same error.
There was a problem hiding this comment.
because there is no convertion from script_value to utils::http::headers or any std::unordered_map:
const auto array = args[0].as<scripting::array>();
const auto keys = array.get_keys();
utils::http::headers headers{};
for (const auto& key : keys)
{
const auto value = array[key];
if (!key.is<std::string>() || !value.is<std::string>())
{
continue;
}
const auto key_str = key.as<std::string>();
headers[key_str] = value.as<std::string>();
}
It works POGGERS
|
Thank you for the help fed. Such an obvious solution and here I was going crazy LOL... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have written code to support POST HTTP requests, just like GET HTTP request (httpget).
Function in production will look like this:
httppost(url <string>, data <array/json string>, headers <array>)This will solve issues #46 and #32 too.