Extending DevCommand metadata for allowing untyped pushing of DevCommand to Commands #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you link to your prototype in the RFC as well? Probably in the implementation details. I'd like to make it clear that this design has been proven to work. |
|
Won't it be a problem that my code is in the bad coding style a bit? I won't have time to clean it until this weekend at least. |
|
Nope, that's fine for now! All we really care about is "this basically works", not "this is ready to upstream". |
Added |
alice-i-cecile
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And fixing geting type info in traits
RENDERED