Make application initialization take a struct #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This explicitly names the thing that's being passed in when initializing the Alice application in another app. It also sets things up so that either state backends or chat backends could be specified in the same struct. Backwards compatibility is not kept meaning this is a breaking change in the API.
The code block for setting up the alice application contains the new method for setting the handlers you want Alice to use
|
This doesn't seem to work with a real world bot. Closing so I can go back to the drawing board. |
|
I discovered that this does indeed actually work, so 🎉 |
|
let's review deployment strategies before merging this since it's breaking |
| Alice.Handlers.GoogleImages | ||
| ] } ] | ||
| Alice, %{ | ||
| :handlers => [ |
|
Switched the hashrockets to colons. Do we still need to talk deployment strategies? |
|
I just want to wait to merge until we're ready to release 0.4.0 right away. In the meantime we can keep releasing any small changes under 0.3.x. That is, unless we make a 0.3 branch that doesn't contain this and then merge this to master. I might do that. |
|
ok, I made a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This explicitly names the thing that's being passed in when initializing the Alice application in another elixir app. It also sets things up so that either state backends or chat backends could be specified in the same struct (but that's future stuff).
This is a breaking change. Backwards compatibility is not kept.
README is updated. Do we need to update any other documentation before merging this PR?