Add SLB PayByBandwidth test case

alibaba · Aug 23, 2018 · ae5186e · ae5186e
1 parent b9a75b2
commit ae5186e
Show file tree

Hide file tree

Showing 4 changed files with 43 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -11,6 +11,7 @@ FEATURES:
 
 IMPROVEMENTS:
 
+- Add SLB PayByBandwidth test case ([#625](https://github.com/alibaba/terraform-provider/pull/625))
 - Improve snat entry test case ([#624](https://github.com/alibaba/terraform-provider/pull/624))
 - Allow empty list of SLBs as arg to ESG ([#621](https://github.com/alibaba/terraform-provider/pull/621))
 - Improve docs vroute_entry ([#619](https://github.com/alibaba/terraform-provider/pull/619))

diff --git a/alicloud/resource_alicloud_slb_attachment_test.go b/alicloud/resource_alicloud_slb_attachment_test.go
@@ -30,7 +30,6 @@ func TestAccAlicloudSlbAttachment_basic(t *testing.T) {
 		Providers:     testAccProviders,
 		CheckDestroy:  testAccCheckSlbDestroy,
 		Steps: []resource.TestStep{
-			//test internet_charge_type is paybybandwidth
 			resource.TestStep{
 				Config: testAccSlbAttachment,
 				Check: resource.ComposeTestCheckFunc(

diff --git a/alicloud/resource_alicloud_slb_listener_test.go b/alicloud/resource_alicloud_slb_listener_test.go
@@ -220,7 +220,7 @@ resource "alicloud_slb_listener" "tcp" {
 const testAccSlbListenerUdp = `
 resource "alicloud_slb" "instance" {
   name = "tf_test_slb_udp"
-  internet_charge_type = "PayByBandwidth"
+  internet_charge_type = "PayByTraffic"
   internet = true
   bandwidth = 20
 }

diff --git a/alicloud/resource_alicloud_slb_test.go b/alicloud/resource_alicloud_slb_test.go
@@ -10,6 +10,34 @@ import (
 	"github.com/hashicorp/terraform/terraform"
 )
 
+//test internet_charge_type is PayByBandwidth and it only support China mainland region
+func TestAccAlicloudSlb_paybybandwidth(t *testing.T) {
+	var slb slb.DescribeLoadBalancerAttributeResponse
+
+	resource.Test(t, resource.TestCase{
+		PreCheck: func() {
+			testAccPreCheck(t)
+		},
+
+		// module name
+		IDRefreshName: "alicloud_slb.bandwidth",
+		Providers:     testAccProviders,
+		CheckDestroy:  testAccCheckSlbDestroy,
+		Steps: []resource.TestStep{
+			resource.TestStep{
+				Config: testAccSlbPayByBandwidth,
+				Check: resource.ComposeTestCheckFunc(
+					testAccCheckSlbExists("alicloud_slb.bandwidth", &slb),
+					resource.TestCheckResourceAttr(
+						"alicloud_slb.bandwidth", "name", "tf_test_slb_paybybandwidth"),
+					resource.TestCheckResourceAttr(
+						"alicloud_slb.bandwidth", "internet_charge_type", "PayByBandwidth"),
+				),
+			},
+		},
+	})
+}
+
 func TestAccAlicloudSlb_vpc(t *testing.T) {
 	var slb slb.DescribeLoadBalancerAttributeResponse
 
@@ -113,6 +141,19 @@ func testAccCheckSlbDestroy(s *terraform.State) error {
 	return nil
 }
 
+const testAccSlbPayByBandwidth = `
+provider "alicloud" {
+	region = "cn-hangzhou"
+}
+
+resource "alicloud_slb" "bandwidth" {
+  name = "tf_test_slb_paybybandwidth"
+  specification = "slb.s2.medium"
+  internet_charge_type = "PayByBandwidth"
+  internet = true
+}
+`
+
 const testAccSlb4Vpc = `
 data "alicloud_zones" "default" {
 	"available_resource_creation"= "VSwitch"