bugfix: fix pouchd cannot listen tcp address #917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HusterWan
force-pushed
the
zr/fix-pouchd-cannot-listen-tcp-address
branch
from
a214b96 to
dce54bd
Compare
Signed-off-by: Michael Wan <[email protected]>
HusterWan
force-pushed
the
zr/fix-pouchd-cannot-listen-tcp-address
branch
from
dce54bd to
f9f4d21
Compare
Codecov Report
@@ Coverage Diff @@
## master #917 +/- ##
=======================================
Coverage 13.66% 13.66%
=======================================
Files 121 121
Lines 7667 7667
=======================================
Hits 1048 1048
Misses 6529 6529
Partials 90 90
Continue to review full report at Codecov.
|
|
@Letty5411 maybe we should add some test case for pouch daemon. |
|
LGTM |
pouchrobot
added
the
LGTM
This was referenced Mar 23, 2018
HusterWan
added a commit
to HusterWan/pouch
that referenced
this pull request
Mar 23, 2018
Signed-off-by: Michael Wan <[email protected]>
Merged
allencloud
added a commit
that referenced
this pull request
Mar 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Michael Wan [email protected]
Ⅰ. Describe what this PR did
Set flagSet := cmd.PersistentFlags() in main.go
Ⅱ. Does this pull request fix one issue?
fixes #916
I know it works, but i still don't know why, may @allencloud , @skoo87 can tell me why :)
Ⅲ. Describe how you did it
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews